Re: [PATCH] selftests/mm: Fix memleak in migration benchmark

From: David Hildenbrand (Arm)

Date: Mon Jul 13 2026 - 05:39:16 EST


On 7/13/26 10:07, Hongfu Li wrote:
> Hi, Lorenzo
>
> On 7/11/26 3:31 PM, Lorenzo Stoakes wrote:
>> On Wed, Jul 08, 2026 at 06:37:05PM +0800, Hongfu Li wrote:
>>> Several early return paths in run_migration_benchmark() skip
>>> hmm_buffer_free(), leaking the buffer. Replace with a single cleanup
>>> label.
>>>
>>> Signed-off-by: Hongfu Li <lihongfu@xxxxxxxxxx>
>> LGTM. With the Fixes tag added as requested by David, feel free to add:
>>
>> Reviewed-by: Lorenzo Stoakes <ljs@xxxxxxxxxx>
>
>
> Thank you for your review.
>
> As suggested by David, I have added the Fixes tag in v2. The patch
> has now been applied to the mm-new branch. 
>
> Since the patch has already been merged into the public branch, I am
> unable to modify the commit message to add your Reviewed-by tag 
> after merging. However, I truly appreciate your review.

If it's not in mm-stable / mm-hotfixes-stable or upstream, Andrew can always
modify the commit (which I assume he will do) or you can resend.

So far this patch seems to only be in mm-new ... which is far, far away from
upstream.

--
Cheers,

David