Re: [PATCH v3 2/5] minix: add base iomap begin/end functions

From: Christoph Hellwig

Date: Mon Jul 13 2026 - 05:49:47 EST


On Sat, Jul 11, 2026 at 01:59:06PM -0700, Jeremy Bingham wrote:
> Adds a new file, iomap.c, to fs/minix. This provides minix_iomap_begin,
> which is the iomap-based version of get_block in itree_common.c. It also
> provides minix_iomap_end, which is a no-op but required by the iomap_ops
> struct. This also undoes the nest of gotos inherited from get_block and
> uses a set of helper functions instead.

You don't need to describe what you do, you need to decribe why you
do it. Bonus points for explaining things like design tradeoffs.