Re: [PATCH] mm: memcg-v1: make mem_cgroup_oom_notify_cb() return void

[Michal Hocko]

On Mon 13-07-26 17:37:37, Guopeng Zhang wrote:
> From: Guopeng Zhang <zhangguopeng@xxxxxxxxxx>
> 
> Commit 7d74b06f240f ("memcg: use for_each_mem_cgroup") replaced the
> mem_cgroup_walk_tree() call in mem_cgroup_oom_notify() with
> for_each_mem_cgroup_tree(), but left mem_cgroup_oom_notify_cb() with the
> int return type required by the old callback interface.
> 
> The function now has a single direct caller and no failure path. Make it
> return void.
> 
> Signed-off-by: Guopeng Zhang <zhangguopeng@xxxxxxxxxx>

Acked-by: Michal Hocko <mhocko@xxxxxxxx>
Thanks!

> ---
>  mm/memcontrol-v1.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/mm/memcontrol-v1.c b/mm/memcontrol-v1.c
> index e8b6e1560278..73bea1b5c8dd 100644
> --- a/mm/memcontrol-v1.c
> +++ b/mm/memcontrol-v1.c
> @@ -752,7 +752,7 @@ static int compare_thresholds(const void *a, const void *b)
>  	return 0;
>  }
>  
> -static int mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg)
> +static void mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg)
>  {
>  	struct mem_cgroup_eventfd_list *ev;
>  
> @@ -762,7 +762,6 @@ static int mem_cgroup_oom_notify_cb(struct mem_cgroup *memcg)
>  		eventfd_signal(ev->eventfd);
>  
>  	spin_unlock(&memcg_oom_lock);
> -	return 0;
>  }
>  
>  static void mem_cgroup_oom_notify(struct mem_cgroup *memcg)
> -- 
> 2.43.0

-- 
Michal Hocko
SUSE Labs