Re: [PATCH next] drivers/bus/fsl-mc: Use strscpy() to copy strings into arrays

From: Ioana Ciornei

Date: Mon Jul 13 2026 - 07:11:10 EST


On Sat, Jul 04, 2026 at 11:10:18AM +0200, Christophe Leroy (CS GROUP) wrote:
>
>
> Le 08/06/2026 à 11:54, david.laight.linux@xxxxxxxxx a écrit :
> > From: David Laight <david.laight.linux@xxxxxxxxx>
> >
> > Replacing strcpy() with strscpy() ensures than overflow of the target
> > buffer cannot happen.
> >
> > Signed-off-by: David Laight <david.laight.linux@xxxxxxxxx>
> > ---
> > This is one of a group of patches that remove potentially unbounded
> > strcpy() calls.
> >
> > They are mostly replaced by strscpy() or, when strlen() has just been
> > called, with memcpy() (usually including the '\0').
> >
> > Calls with copy string literals into arrays are left unchanged.
> > They are safe and easily detected as such.
> >
> > The changes were made by getting the compiler to detect the calls and
> > then fixing the code by hand.
> >
> > Note that all the changes are only compile tested.
> >
> > Some Makefiles were changed to allow files to contain strcpy().
> > As well as 'difficult to fix' files, this included 'show' functions
> > as they really need to use sysfs_emit() or seq_printf().
> >
> > All the patches are being sent individually to avoid very long cc lists.
> > Apologies for the terse commit messages and likely unexpected tags.
> > (There are about 100 patches in total.)
> >
> > drivers/bus/fsl-mc/fsl-mc-bus.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Do you expect this patch to go via individual trees or will you apply them
> all together in a given tree ?
>
> Ioana, as usual I can take it via soc/fsl/ with your Ack.

Yes, you can take the patch through soc/fsl.

Reviewed-by: Ioana Ciornei <ioana.ciornei@xxxxxxx>