Re: [PATCH v5 19/19] arm64: dts: qcom: shikra: Add support for DISPCC/GPUCC nodes

[Imran Shaik]

On 06-07-2026 06:30 pm, Konrad Dybcio wrote:
> On 7/2/26 8:31 PM, Imran Shaik wrote:
> > Add support for Display clock controller and GPU clock controller nodes
> > on Qualcomm Shikra SoCs.
> >
> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> > Signed-off-by: Imran Shaik <imran.shaik@xxxxxxxxxxxxxxxx>
> > ---
>
> [...]
>
> > +		dispcc: clock-controller@5f00000 {
> > +			compatible = "qcom,shikra-dispcc", "qcom,qcm2290-dispcc";
> > +			reg = <0x0 0x05f00000 0x0 0x20000>;
> > +			clocks = <&rpmcc RPM_SMD_XO_CLK_SRC>,
> > +				 <&rpmcc RPM_SMD_XO_A_CLK_SRC>,
> > +				 <&gcc GCC_DISP_GPLL0_CLK_SRC>,
> > +				 <&gcc GCC_DISP_GPLL0_DIV_CLK_SRC>,
> > +				 <0>,
> > +				 <0>,
> > +				 <0>,
> > +				 <0>,
> > +				 <&sleep_clk>;
> > +			clock-names = "bi_tcxo",
> > +				      "bi_tcxo_ao",
> > +				      "gcc_disp_gpll0_clk_src",
> > +				      "gcc_disp_gpll0_div_clk_src",
> > +				      "dsi0_phy_pll_out_byteclk",
> > +				      "dsi0_phy_pll_out_dsiclk",
> > +				      "dsi1_phy_pll_out_byteclk",
> > +				      "dsi1_phy_pll_out_dsiclk",
>
> FYI neither Shikra nor Agatti has a functional DSI1_PHY, so
> unless you're worried about some incorrect bootloader version
> toggling them and want Linux to clean them up, adding them is
> no less than unnecessary

Sure, I will drop this patch in next series.

Thanks,
Imran