[PATCH] counter: Remove redundant dev_err()/dev_err_probe()

From: Pan Chuang

Date: Mon Jul 13 2026 - 09:21:51 EST


Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() and devm_request_threaded_irq()
automatically log detailed error messages on failure. Remove the
now-redundant driver-specific dev_err() and dev_err_probe() calls.

Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
---
drivers/counter/stm32-timer-cnt.c | 10 ++--------
drivers/counter/ti-ecap-capture.c | 2 +-
drivers/counter/ti-eqep.c | 2 +-
3 files changed, 4 insertions(+), 10 deletions(-)

diff --git a/drivers/counter/stm32-timer-cnt.c b/drivers/counter/stm32-timer-cnt.c
index a3d8f7a5874e..9eee281350d0 100644
--- a/drivers/counter/stm32-timer-cnt.c
+++ b/drivers/counter/stm32-timer-cnt.c
@@ -759,11 +759,8 @@ static int stm32_timer_cnt_probe(struct platform_device *pdev)
/* All events reported through the global interrupt */
ret = devm_request_irq(&pdev->dev, ddata->irq[0], stm32_timer_cnt_isr,
0, dev_name(dev), counter);
- if (ret) {
- dev_err(dev, "Failed to request irq %d (err %d)\n",
- ddata->irq[0], ret);
+ if (ret)
return ret;
- }
} else {
for (i = 0; i < priv->nr_irqs; i++) {
/*
@@ -775,11 +772,8 @@ static int stm32_timer_cnt_probe(struct platform_device *pdev)

ret = devm_request_irq(&pdev->dev, ddata->irq[i], stm32_timer_cnt_isr,
0, dev_name(dev), counter);
- if (ret) {
- dev_err(dev, "Failed to request irq %d (err %d)\n",
- ddata->irq[i], ret);
+ if (ret)
return ret;
- }
}
}

diff --git a/drivers/counter/ti-ecap-capture.c b/drivers/counter/ti-ecap-capture.c
index f69b6920463f..d77a256f0ed3 100644
--- a/drivers/counter/ti-ecap-capture.c
+++ b/drivers/counter/ti-ecap-capture.c
@@ -513,7 +513,7 @@ static int ecap_cnt_probe(struct platform_device *pdev)

ret = devm_request_irq(dev, ret, ecap_cnt_isr, 0, pdev->name, counter_dev);
if (ret)
- return dev_err_probe(dev, ret, "failed to request irq\n");
+ return ret;

platform_set_drvdata(pdev, counter_dev);

diff --git a/drivers/counter/ti-eqep.c b/drivers/counter/ti-eqep.c
index d9302ec21163..0dda3f2b14c7 100644
--- a/drivers/counter/ti-eqep.c
+++ b/drivers/counter/ti-eqep.c
@@ -526,7 +526,7 @@ static int ti_eqep_probe(struct platform_device *pdev)
err = devm_request_threaded_irq(dev, irq, NULL, ti_eqep_irq_handler,
IRQF_ONESHOT, dev_name(dev), counter);
if (err < 0)
- return dev_err_probe(dev, err, "failed to request IRQ\n");
+ return err;

counter->name = dev_name(dev);
counter->parent = dev;
--
2.34.1