Re: [PATCH 2/2] arm64: dts: qcom: Add Xiaomi 11 Lite 5G NE

[Alex]

On 13/7/26 at 09:52 AM, Konrad Dybcio wrote:
> > +&usb_1 {
> > + /* USB 2.0 only */
>
> Did you test that (with an actual USB3 cable)?

No, I have only tested USB 2.0 operation and do not currently have a
USB 3-capable Type-C cable available. The downstream DTS configures
the generic Yupik primary controller for SuperSpeed, but I could not
verify SuperSpeed operation on Lisa. Therefore, the initial submission
only describes the USB 2.0 configuration that has been tested.

Oleksii


On Mon, Jul 13, 2026 at 9:52 AM Konrad Dybcio
<konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>
> On 7/11/26 8:49 PM, Oleksii Onchul wrote:
> > Add initial support for the Xiaomi 11 Lite 5G NE, codenamed lisa.
> >
> > The supported hardware includes regulators, UFS, SD card, USB, GPU,
> > remote processors, Wi-Fi, Bluetooth, touchscreen, flash LED, thermal
> > sensors and the hardware buttons.
> >
> > Signed-off-by: Oleksii Onchul <oleksiionchul@xxxxxxxxx>
> > ---
>
> [...]
>
> > +     chosen {
> > +             #address-cells = <2>;
> > +             #size-cells = <2>;
> > +             ranges;
> > +
> > +             stdout-path = "serial0:115200n8";
> > +
> > +             framebuffer0: framebuffer@e1000000 {
> > +                     compatible = "simple-framebuffer";
> > +                     reg = <0x0 0xe1000000 0x0 (1080 * 2400 * 4)>;
>
> Please use memory-region instead
>
> [...]
>
> > +             ramoops@a9000000 {
> > +                     compatible = "ramoops";
> > +                     reg = <0x0 0xa9000000 0x0 0x200000>;
> > +                     pmsg-size = <0x200000>;
> > +                     mem-type = <0x02>;
>
> Let's make mem-type decimal. Don't you need ecc-size for reliability?
>
> [...]
>
> > +             regulators {
> > +                     vreg_l1p: ldo1 {
> > +                             regulator-name = "vreg_l1p";
> > +                             regulator-min-microvolt = <1000000>;
> > +                             regulator-max-microvolt = <1200000>;
> > +                             regulator-always-on;
>
> Many/all of these shouldn't be always on. This PMIC normally only
> powers cameras, so dropping this should be fine
>
> [...]
>
> > +&ipa {
> > +     qcom,gsi-loader = "self";
> > +     memory-region = <&ipa_fw_mem>;
>
> These two fill be folded into the SoC DTSI soon
>
> https://lore.kernel.org/all/20260517-ipa-loader-v1-0-3c3764c1b4a3@xxxxxxxxxxxxxxxx/
>
>
> [...]
>
> > +&tlmm {
> > +     /*
> > +      * 32-33: SMB1394 (SPMI)
> > +      * 56-59: fingerprint reader (SPI)
> > +      */
> > +     gpio-reserved-ranges = <32 2>, <48 4>, <56 4>;
>
> What about the <48 4> range?
>
> as a nit, other files place the comments inline with the ranges:
>
> gpio-reserved-ranges = <4 4>, /* EC TZ Secure I3C */
>                                <10 2>, /* OOB UART */
>                                <44 4>; /* Security SPI (TPM) */
>
>
> [...]
>
> > +&usb_1 {
> > +     /* USB 2.0 only */
>
> Did you test that (with an actual USB3 cable)?
>
> Konrad