Re: [PATCH v3 6/8] iio: adc: add ti-ads112c14 driver

[David Lechner]

On 7/12/26 9:11 PM, Jonathan Cameron wrote:
> On Fri, 10 Jul 2026 17:50:39 -0500
> "David Lechner (TI)" <dlechner@xxxxxxxxxxxx> wrote:
> 
>> Add a new driver for the TI ADS112C14/ADS122C14 ADC chips.
>>

...

>> +			 info->device_id,
>> +			 FIELD_GET(ADS112C14_DEVICE_ID_BITS, reg_val));
>> +
>> +	/* Place in single-shot conversion mode to make ready for raw read. */
> Writing a bit called conv mode puts it in single-shot?  (sashiko) 

Sashiko didn't read the datasheet. The options are continuous conversion
mode (0) or single-shot conversion mode (1).

It isn't obvious from the bit name which one is active when the bit
is set, hence the comment.

> 
>> +	ret = regmap_set_bits(data->regmap, ADS112C14_REG_DEVICE_CFG,
>> +			      ADS112C14_DEVICE_CFG_CONV_MODE);
> 
> Thanks,
> 
> Jonathan
> 
>