Re: [PATCH v15 5/6] hwmon: add NXP MC33978/MC34978 driver

[Uwe Kleine-König]

Hello Guenter,

On Mon, Jul 13, 2026 at 06:20:48AM -0700, Guenter Roeck wrote:
> On 7/12/26 15:20, Uwe Kleine-König wrote:
> > Hallo again,
> > 
> > On Fri, Jul 10, 2026 at 12:13:54PM +0200, Oleksij Rempel wrote:
> > > +#include <linux/mod_devicetable.h>
> > 
> > As for patch 6/6: Please use the <linux/device-id/*.h> you actually need
> > only instead of this catch-all header that I want to get rid of.
> > 
> 
> This was only introduced in v7.2-rc2. Not all contributor branches
> (including my hwmon-next branch, which is based off v7.2-rc1)
> are synchronized to that release candidate.

In most cases device drivers don't need to #include
<linux/mod_devicetable.h> explicitly. In this case the driver uses
platform_device_id, and its definition is provided by
<linux/platform_device.h>, so the #include can just be dropped without
needing to be based on -rc2.

Best regards
Uwe

Attachment: signature.asc
Description: PGP signature