Re: [PATCH v3 1/3] dt-bindings: phy: nuvoton,ma35d1-usb2-phy: extend for dual-port and OTG

[Joey Lu]

On 7/10/2026 4:54 PM, Krzysztof Kozlowski wrote:
> On Wed, Jul 08, 2026 at 06:36:04PM +0800, Joey Lu wrote:
> > +  nuvoton,oc-active-high:
> > +    type: boolean
> > +    description:
> > +      When present, the over-current detect input from the VBUS power switch
> > +      is treated as active-high. The default (property absent) is active-low.
> > +      This setting is shared by both USB host ports.
> >   
> >   required:
> >     - compatible
> > @@ -39,7 +78,7 @@ examples:
> >   
> >       usb_phy: usb-phy {
> >           compatible = "nuvoton,ma35d1-usb2-phy";
> > -        clocks = <&clk USBD_GATE>;
> > +        clocks = <&clk HUSBH0_GATE>;
> This change is really redundant. Instead, add optional properties like
> nuvoton,rcalcode and nuvoton,oc-active-high.
>
> The rest looks good, so with above change:
>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> Best regards,
> Krzysztof
Thank you for the review.
Agreed on both points: the clock swap in the example is redundant and I 
will revert it. I will add nuvoton,rcalcode to the example to highlight 
the optional properties. For nuvoton,oc-active-high, since active-low is 
the default, I will leave it out of the example to keep it 
representative of a typical board. I will address this in the next patch 
series.

BR,
Joey