Re: [PATCH v4 3/3] firmware: stratix10-rsu: remove async client before freeing channel in remove()

[NG, TZE YEE]

On 10/7/2026 9:42 pm, Dinh Nguyen wrote:
> 
> 
> On 7/10/26 01:52, tze.yee.ng@xxxxxxxxxx wrote:
>> From: Tze Yee Ng <tze.yee.ng@xxxxxxxxxx>
>>
>> After stratix10_svc_add_async_client() succeeds in probe, remove() must
>> call stratix10_svc_remove_async_client() before
>> stratix10_svc_free_channel(). Otherwise async state is left allocated 
>> while
>> the channel is released.
>>
>> Signed-off-by: Tze Yee Ng <tze.yee.ng@xxxxxxxxxx>
>> ---
>> Changes in v4:
>> - Rebased onto dinguyen/socfpga_svc_fixes_for_v7.2.
>> - Narrowed scope to stratix10_rsu_remove() only (+1 line). Probe error
>>    paths, return 0 on success, Fixes:, and Cc: stable@ dropped; probe
>>    teardown is covered by bfd2eb9bba54 on the new base.
>> - Title updated: "... in remove()" (was "... on probe errors" in v3).
>>
>> Changes in v3:
>> - No code changes in all patches, only put Cc: stable@xxxxxxxxxxxxxxx 
>> # 6.19+
>>    in the sign-off block for the Fixes: tag in Patch 3.
>>
>> Changes in v2:
>> - Fix patch title.
>> - Move the fix description to the end of the patch.
>> ---
>>   drivers/firmware/stratix10-rsu.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/firmware/stratix10-rsu.c b/drivers/firmware/ 
>> stratix10-rsu.c
>> index a36c4e3d6975..cdda0c4410f8 100644
>> --- a/drivers/firmware/stratix10-rsu.c
>> +++ b/drivers/firmware/stratix10-rsu.c
>> @@ -1054,6 +1054,7 @@ static void stratix10_rsu_remove(struct 
>> platform_device *pdev)
>>   {
>>       struct stratix10_rsu_priv *priv = platform_get_drvdata(pdev);
>> +    stratix10_svc_remove_async_client(priv->chan);
>>       stratix10_svc_free_channel(priv->chan);
>>   }
> 
> Your original patch has a Fixes tag.
> 
> Dinh
> 

Hi Dinh,

After rebase, I found the fixes are covered by commit bfd2eb9bba54 on 
the new base. That's why the Fixes tag is dropped in this new revision.

Regards,
Tze Yee