Re: [PATCH] cpufreq: Remove redundant dev_err()

[Viresh Kumar]

On 14-07-26, 10:39, Zhongqiu Han wrote:
> On 7/13/2026 9:11 PM, Pan Chuang wrote:
> > Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> > devm_request_*_irq()"), devm_request_irq() automatically logs
> > detailed error messages on failure. Remove the now-redundant
> > driver-specific dev_err() calls.
> > 
> > Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
> 
> Looks good to me overall.
> 
> However the subject is too generic and can be misread as a cpufreq core
> fix. Please scope it to the driver, e.g:
> "cpufreq: brcmstb-avs: Remove redundant dev_err() on IRQ request failure".

Fixed.

> With that:
> 
> Reviewed-by: Zhongqiu Han <zhongqiu.han@xxxxxxxxxxxxxxxx>

Applied. Thanks.

-- 
viresh