Re: [RFC PATCH] crypto: pcrypt - Disallow nesting of the pcrypt wrapper

[Steffen Klassert]

On Sun, Jul 12, 2026 at 10:46:54PM -0400, Eric Biggers wrote:
> On Mon, Jul 13, 2026 at 12:30:18PM +1000, Herbert Xu wrote:
> > This doesn't fix the problem completely since you can nest in other
> > ways, e.g., pcrypt(cryptd(pcrypt(...))).  How about handling the name-
> > too-long error more gracefully?
> 
> Could we just delete pcrypt instead of continuing to try to fix all the
> weird problems it has?  A web search for pcrypt just finds CVEs and
> advice not to use it, e.g.
> https://github.com/libreswan/libreswan/wiki/Internals:-Cryptographic-Acceleration#obsoleted-ipsec-accelerations

The comments on pctypt there are not quite right, but it
is obsolte, that's correct. It was usefull back in the
days when the overhead of (slow) software crypto was
high compared to an IPI. I guess there are not many
users left, so I'm OK with removing it.