Re: [PATCH v1 09/20] gpio: Add missing dmi module annotations

[Andy Shevchenko]

On Tue, Jul 14, 2026 at 11:23:48AM +0300, Andy Shevchenko wrote:
> On Tue, Jul 14, 2026 at 09:24:10AM +0200, Uwe Kleine-König (The Capable Hub) wrote:
> > A driver module matching devices using an dmi device id table is
> > supposed to declare that in the module's metadata. Add this information
> > for two drivers that failed to declare these.
> 
> No, it is not supposed. Why?

...

> These are quirks and enumerating by quirks sounds weird.

Saying that I recall that we have also PCI ID tables and ACPI for the other
purposes than enumeration. Please, revisit all your patches with the same idea
and remove those MODULE_DEVICE_TABLE():s which are not required or actually
must not be there. Some drivers have comments regarding to the absence of the
macro, but some may not. Feel free to add a comment there.

-- 
With Best Regards,
Andy Shevchenko