Re: [PATCH v11 2/7] i2c: mux: add idle_state property to i2c_mux_core

[Andy Shevchenko]

On Mon, Jul 13, 2026 at 09:19:58AM +0200, Marcus Folkesson wrote:
> Muxes treat their channels differently when idle.
> Let the mux core have this information to make it available for
> internal use.
> Reuse the same state values used by CONFIG_MULTIPLEXER.
> 
> Possible idle states are:
> - MUX_IDLE_AS_IS: Leave channels as is when idle
> - MUX_IDLE_DISCONNECT: Disconnect channel (set HiZ when idle)
> - <n>: Enable channel n when idle

Here and in the comment in the code I would elaborate a bit to justify signed
type for the field. For example, put it as

  " - <n>: Enable channel n (starting from 0) when idle"

> Default value is set to MUX_IDLE_AS_IS.

Otherwise LGTM, FWIW,
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>

-- 
With Best Regards,
Andy Shevchenko