Re: [PATCH v2 1/4] iio: light: opt4001: Fix reversed GENMASK() arguments in fault count mask

[Nikhil Gautam]

On 13-07-2026 09:36 pm, Andy Shevchenko wrote:
> On Mon, Jul 13, 2026 at 09:27:33AM +0530, Nikhil Gautam wrote:
> > GENMASK(h, l) requires h >= l, but OPT4001_CTRL_FAULT_COUNT is defined
> > as GENMASK(0, 1). The define is currently unused so there is no
> > functional impact, but fix it before anyone builds on it, and add the
> > _MASK suffix for consistency with the neighbouring definitions.
> Cam you check my comments on previous version? This one seems has the same
> issues.
Yes, updated v3 by replacing tabs by spaces

Thanks,
Nikhil