Re: [PATCH net-next v8 2/2] dinghai: add hardware register access and PCI? capability scanning

[Jiri Pirko]

Mon, Jul 13, 2026 at 04:28:04PM +0200, han.junyang@xxxxxxxxxx wrote:


[..]

>@@ -48,5 +85,34 @@ struct zxdh_pf_device {
> void *dh_core_alloc_priv(struct dh_core_dev *dh_dev, size_t size);
> void dh_core_free_priv(struct dh_core_dev *dh_dev);
> void dh_pf_pci_close(struct dh_core_dev *dev);
>+int zxdh_pf_pci_find_capability(struct pci_dev *pdev, u8 cfg_type,
>+				u32 ioresource_types, int *bars);
>+void __iomem *zxdh_pf_map_capability(struct dh_core_dev *dh_dev, int off,
>+				     size_t minlen, u32 align,
>+				     u32 start, u32 size,
>+				     size_t *len, resource_size_t *pa,
>+				     u32 *bar_off);
>+int zxdh_pf_common_cfg_init(struct dh_core_dev *dh_dev);
>+int zxdh_pf_notify_cfg_init(struct dh_core_dev *dh_dev);
>+int zxdh_pf_device_cfg_init(struct dh_core_dev *dh_dev);
>+void zxdh_pf_modern_cfg_uninit(struct dh_core_dev *dh_dev);
>+int zxdh_pf_modern_cfg_init(struct dh_core_dev *dh_dev);
>+u16 zxdh_pf_get_queue_notify_off(struct dh_core_dev *dh_dev,
>+				 u16 phy_index, u16 index);
>+void __iomem *zxdh_pf_map_vq_notify(struct dh_core_dev *dh_dev,
>+				     u16 phy_index, u16 index,
>+				     resource_size_t *pa);
>+void zxdh_pf_unmap_vq_notify(struct dh_core_dev *dh_dev, void __iomem *priv);
>+void zxdh_pf_set_status(struct dh_core_dev *dh_dev, u8 status);
>+u8 zxdh_pf_get_status(struct dh_core_dev *dh_dev);
>+u8 zxdh_pf_get_cfg_gen(struct dh_core_dev *dh_dev);
>+void zxdh_pf_get_vf_mac(struct dh_core_dev *dh_dev, u8 *mac, int vf_id);
>+void zxdh_pf_set_vf_mac_reg(struct zxdh_pf_device *pf_dev,
>+			    u8 *mac, int vf_id);
>+void zxdh_pf_set_vf_mac(struct dh_core_dev *dh_dev, u8 *mac, int vf_id);

I don't follow. You introduce functions yet you never use them? When you
introduce some function, you need to use it in the same patchset.

Honestly, I would expect quite different patchset quality in V8 :/


>+void zxdh_set_mac(struct dh_core_dev *dh_dev, u8 *mac);
>+void zxdh_get_mac(struct dh_core_dev *dh_dev, u8 *mac);
>+u64 zxdh_pf_get_features(struct dh_core_dev *dh_dev);
>+void zxdh_pf_set_features(struct dh_core_dev *dh_dev, u64 features);
>
> #endif /* __ZXDH_EN_PF_H__ */
>-- 
>2.27.0
>