Re: [PATCH] PCI: rcar-gen4: Inline GIC_TRANSLATER offset macro

[Marek Vasut]

On 7/14/26 9:54 AM, Geert Uytterhoeven wrote:

Hello Geert,

> > > > So in the end, it is either this patch or limit the build to
> > > > arm/arm64 . At least this patch still allows building this driver
> > > > with more compilers on the various build bots, so I would opt for
> > > > this patch here.
> > >
> > > I like the build coverage, but duplicating the #define doesn't really
> > > seem good to me.  It makes readability worse because cscope/tags now
> > > sees two definitions without an obvious reason.
> >
> > I can rename the macro, or ... sigh ... I can reduce the driver to build
>
> That would obfuscate the code?
>
> > only on ARM/ARM64. Which one do you prefer ?
>
> Just add the dependency for compile-testing, just like
> PCIE_IPROC_PLATFORM does.

I will send a V2 shortly.