Re: [PATCH v5 01/14] dt-bindings: leds: Document TI LM3533 LED controller

[Svyatoslav Ryhel]

пт, 3 лип. 2026 р. о 12:49 Johan Hovold <johan@xxxxxxxxxx> пише:
>
> On Wed, Jun 17, 2026 at 11:00:18AM +0300, Svyatoslav Ryhel wrote:
> > Document the LM3533 - a complete power source for backlight, keypad and
> > indicator LEDs in smartphone handsets. The high-voltage inductive boost
> > converter provides the power for two series LED strings display backlight
> > and keypad functions.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> > Reviewed-by: Jonathan Cameron <jic23@xxxxxxxxxx> #for light sensor
> > Reviewed-by: Daniel Thompson (RISCstar) <danielt@xxxxxxxxxx> #for backlight
> > Reviewed-by: Rob Herring (Arm) <robh@xxxxxxxxxx>
>
> > +examples:
> > +  - |
> > +    #include <dt-bindings/gpio/gpio.h>
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +
> > +    i2c {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        led-controller@36 {
> > +            compatible = "ti,lm3533";
> > +            reg = <0x36>;
> > +
> > +            enable-gpios = <&gpio 110 GPIO_ACTIVE_HIGH>;
> > +            vin-supply = <&vdd_3v3_bat>;
> > +
> > +            ti,boost-ovp-microvolt = <24000000>;
> > +            ti,boost-freq-hz = <500000>;
> > +
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            backlight@0 {
> > +                compatible = "ti,lm3533-backlight";
> > +                reg = <0>;
> > +
> > +                default-brightness = <113>;
> > +
> > +                led-max-microamp = <23400>;
> > +                led-sources = <0 1>;
> > +            };
> > +
> > +            led@2 {
> > +                compatible = "ti,lm3533-leds";
> > +                reg = <2>;
> > +
> > +                led-max-microamp = <23400>;
> > +                led-sources = <0 1>;
> > +            };
> > +
> > +            led@4 {
> > +                compatible = "ti,lm3533-leds";
> > +                reg = <4>;
> > +
> > +                led-max-microamp = <23400>;
> > +                led-sources = <2>;
> > +            };
> > +
> > +            led@5 {
> > +                compatible = "ti,lm3533-leds";
> > +                reg = <5>;
> > +
> > +                led-max-microamp = <23400>;
> > +                led-sources = <3 4>;
> > +            };
> > +
> > +            light-sensor {
>
> Doesn't the binding (or dts) checker complain about this node not having
> an address?
>

No it does not

> > +                compatible = "ti,lm3533-als";
> > +
> > +                interrupt-parent = <&gpio>;
> > +                interrupts = <80 IRQ_TYPE_LEVEL_LOW>;
> > +
> > +                ti,pwm-mode;
> > +            };
> > +        };
> > +    };
> > +...
>
> Johan