Re: [PATCH 3/6] iio: adc: adi-axi-adc: Add support for CRC

[Nuno Sá]

On Fri, Jul 10, 2026 at 01:46:17AM +0100, Jonathan Cameron wrote:
> On Thu, 9 Jul 2026 10:50:14 +0200
> Janani Sunil <janani.sunil@xxxxxxxxxx> wrote:
> 
> > Add support for enabling and disabling Cyclic Redundancy Check (CRC)
> > processing in the AXI ADC backend. CRC provides data integrity verification
> > for high-speed ADC data streams, ensuring reliable data transfer between
> > the ADC frontend and backend processing systems.
> > 
> > Signed-off-by: Janani Sunil <janani.sunil@xxxxxxxxxx>
> The 'other things' I found bit from Sashiko is interesting. Far as I can
> tell it is right and [devm_]mutex_init() is missing for lock
> in struct adi_axi_adc_state().  
> 

Ouch! Yes, I was also wondering about the lock comment.

> Nuno, looks like it was from:
> 7ecb8ee5c93b ("iio: adc: adi-axi-adc: support digital interface calibration")
> 
> Which indeed adds the lock with a mutex_init()

You mean without :)?

I'll send a patch fixing it!

- Nuno Sá
> 
> Jonathan
> 
> >  static const struct iio_backend_info adi_axi_adc_generic = {
> > 
>