Re: [PATCH][next] iio: adc: make read-only const array config static
From: Andy Shevchenko
Date: Tue Jul 14 2026 - 13:08:28 EST
On Tue, Jul 14, 2026 at 05:50:12PM +0100, Colin Ian King wrote:
> Don't populate the read-only const array config on the stack at run
> time, instead make it static.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
...
In all patches like this it's always a bikeshedding possible of moving static
data outside of a function. I have no strong opinion in these cases (when the
data solely used by a single function), but in general it might give different
readability experience (it's harder to notice static data in the local function
definition block). So I leave this exercise to the maintainers of the respective
pieces of the code.
--
With Best Regards,
Andy Shevchenko