Re: [PATCH v4 5/8] dt-bindings: iio: adc: add ti,ads122c14

[David Lechner]

On 7/14/26 6:21 PM, David Lechner (TI) wrote:
> Add new bindings for ti,ads122c14 and similar devices.
> 
> This is an ADC that is primarily intended for use with resistive sensors
> (RTD, thermocouple, Wheatstone bridge, etc.). There are a few unusual
> properties because of this. In particular, the reference voltage source
> and current output requirements can be different for each measurement,
> so these are included in the channel bindings.
> 
> The REFP/REFN reference voltage is usually just connected to a resistor
> that is being driven by the ADC's current outputs, so there is special
> property for this case rather than requiring a regulator to be defined
> to represent that.
> 
> Reviewed-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx>
> Signed-off-by: David Lechner (TI) <dlechner@xxxxxxxxxxxx>
> ---
> v4 changes:
> * Generalize temperature sensors to resistive sensors in commit message
>   and bindings description.
> * Remove leftover paragraph from v1 in commit message.
> * Added if to make clocks and drdy interrupts mutually exclusive.
> 

...

> +# /DRDY out and CLK in use the same AIN7/GPIO3 pin.
> +if:
> +  properties:
> +    interrupt-names:
> +      contains:
> +        const: drdy
> +then:
> +  properties:
> +    clocks: false

Doh, I thought I tested all combinations, but must have missed one.

Sashiko correctly caught that this is wrong when interrupt-names
is omitted and clocks is present.

Tested correct is:

# /DRDY out and CLK in use the same AIN7/GPIO3 pin.
if:
  required:
    - interrupt-names
  properties:
    interrupt-names:
      contains:
        const: drdy
then:
  properties:
    clocks: false


And my responses to other Sashiko mentions on this patch are the same
as last time [1].

[1]: https://lore.kernel.org/all/f1c5be4b-6bbd-41d9-a152-ee480988f44d@xxxxxxxxxxxx/