Re: [PATCH 4/4] HID: Intel-thc-hid: Intel-quickspi: Remove redundant dev_err()

[Pan Chuang]

On 2026/7/14 8:50, Xu, Even wrote:
> Thanks for the patch!
>
> If this is the case, can you also do the same change for intel-quicki2c driver?
>
> Best Regards,
> Even Xu
>
>> -----Original Message-----
>> From: Pan Chuang <panchuang@xxxxxxxx>
>> Sent: Monday, July 13, 2026 9:25 PM
>> To: Xu, Even <even.xu@xxxxxxxxx>; Sun, Xinpeng <xinpeng.sun@xxxxxxxxx>; Jiri
>> Kosina <jikos@xxxxxxxxxx>; Benjamin Tissoires <bentiss@xxxxxxxxxx>; Pan
>> Chuang <panchuang@xxxxxxxx>; Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>;
>> Abhishek Tamboli <abhishektamboli9@xxxxxxxxx>; Danny D.
>> <d3z.the.dev@xxxxxxxxx>; open list:HID CORE LAYER <linux-
>> input@xxxxxxxxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>
>> Subject: [PATCH 4/4] HID: Intel-thc-hid: Intel-quickspi: Remove redundant
>> dev_err()
>>
>> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
>> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
>> detailed error messages on failure. Remove the now-redundant driver-specific
>> dev_err() calls.
>>
>> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>
>> ---
>>  drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c | 5 +----
>>  1 file changed, 1 insertion(+), 4 deletions(-)
>>
>> diff --git a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
>> b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
>> index 4ae2e1718b30..504ef3c842ab 100644
>> --- a/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
>> +++ b/drivers/hid/intel-thc-hid/intel-quickspi/pci-quickspi.c
>> @@ -636,11 +636,8 @@ static int quickspi_probe(struct pci_dev *pdev,
>>  					quickspi_irq_thread_handler,
>>  					IRQF_ONESHOT, KBUILD_MODNAME,
>>  					qsdev);
>> -	if (ret) {
>> -		dev_err(&pdev->dev,
>> -			"Failed to request threaded IRQ, irq = %d.\n", pdev-
>>> irq);
>> +	if (ret)
>>  		goto dev_deinit;
>> -	}
>>
>>  	ret = reset_tic(qsdev);
>>  	if (ret) {
>> --
>> 2.34.1
>
Sure, I will apply the same change to the intel-quicki2c driver as well.

Best Regards,
PanChuang