Re: [PATCH v4] ALSA: hda/realtek: Add inverted LED quirk for HP ZBook 8 G2a

[Takashi Iwai]

On Wed, 15 Jul 2026 06:18:55 +0200,
Chris Chiu wrote:
> 
> From: Chris Chiu <chris.chiu@xxxxxxxxxxxxx>
> 
> HP ZBook 8 G2a 14 and 16 (SSIDs 0x103c:0x8f94, 0x103c:0x8f95) use the
> Realtek ALC245 codec with a TAS2781 amplifier via I2C. They share the
> same hardware configuration as the existing 0x8f40/0x8f41/0x8f42/0x8f62
> models but have inverted speaker mute LED polarity, so the existing
> ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED quirk drives the LED backwards:
> off when muted and on when unmuted.
> 
> Add a dedicated quirk with inverted COEF values. These are speaker-only
> models without an HP pin, so the LED is driven directly through the
> vmaster_mute hook; there is no need to probe the HP pin at runtime since
> the configuration is static and known per SSID.
> 
> Signed-off-by: Chris Chiu <chris.chiu@xxxxxxxxxxxxx>

Now it looks much better.  But the patch isn't applied cleanly on the
current code.

Could you rebase to the latest tree and resubmit?


thanks,

Takashi