Re: [PATCH v4] iio: light: opt3001: split opt3001_get_processed() logic

[Joshua Crofts]

On Tue, 14 Jul 2026 20:04:10 +0300
Andy Shevchenko <andriy.shevchenko@xxxxxxxxx> wrote:
> > -	if (ret < 0) {
> > +	if (ret < 0)  
> 
> At some point consider dropping ' < 0' pieces for the i2c_smbus_write_*() cases.
> Read cases are different, of course.
> 
> >  		dev_err(dev, "failed to write register %02x\n",
> >  			OPT3001_CONFIGURATION);
> > +
> > +	return ret;  
> 

Even after an 8-part patch set, this driver still needs cleaning up!

-- 
Kind regards

CJD