Re: [PATCH v3 14/17] verification/rvgen: Add selftests for rvgen kunit

[Gabriele Monaco]

On Wed, 2026-07-15 at 01:49 +0800, Wen Yang wrote:
> 
> Note that the same typo (handle_sample_event) appears in the other two
> LTL golden files added in patch 05/17 as well: ltl_pertask.c and
> test_ltl.c. The root is likely in the rvgen LTL template itself, so
> the fix there would regenerate all three consistently.

Yeah that's trivial to fix.

> Understood on the intent. One small concern:  MODULE_AUTHOR(/* TODO */)
> is subtly different from an XXX comment — a C preprocessor strips the
> comment before macro expansion, leaving  MODULE_AUTHOR() with an empty
> argument. When the user does go to compile, they get a cryptic error
> rather than a clear "fill this in" hint.

Well, I believe a compiler failure was indeed the original intent (that's kinda
what we do in rv_attach_trace_probe), to avoid unauthored monitors.

Anyway an unauthored monitor isn't as bad as a missing tracepoint, so probably I
could make the LTL template consistent with the others.

Unless Nam has concerns with that.

Thanks,
Gabriele