Re: [PATCH 14/18] thermal/drivers/renesas: Remove redundant dev_err()

[Niklas Söderlund]

Hi Pan,

Thanks for your work.

On 2026-07-09 10:30:17 +0800, Pan Chuang wrote:
> The devm_request_threaded_irq() now automatically logs detailed error
> messages on failure. This eliminates the need for driver-specific
> dev_err() calls that previously printed generic messages.
> 
> Signed-off-by: Pan Chuang <panchuang@xxxxxxxx>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
>  drivers/thermal/renesas/rcar_thermal.c  | 4 +---
>  drivers/thermal/renesas/rzg3e_thermal.c | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/thermal/renesas/rcar_thermal.c b/drivers/thermal/renesas/rcar_thermal.c
> index 6e5dcac5d47a..cf80e2655416 100644
> --- a/drivers/thermal/renesas/rcar_thermal.c
> +++ b/drivers/thermal/renesas/rcar_thermal.c
> @@ -446,10 +446,8 @@ static int rcar_thermal_probe(struct platform_device *pdev)
>  
>  		ret = devm_request_irq(dev, irq, rcar_thermal_irq,
>  				       IRQF_SHARED, dev_name(dev), common);
> -		if (ret) {
> -			dev_err(dev, "irq request failed\n");
> +		if (ret)
>  			goto error_unregister;
> -		}
>  
>  		/* update ENR bits */
>  		if (chip->irq_per_ch)
> diff --git a/drivers/thermal/renesas/rzg3e_thermal.c b/drivers/thermal/renesas/rzg3e_thermal.c
> index f0e29fe633db..c44f5b8858d0 100644
> --- a/drivers/thermal/renesas/rzg3e_thermal.c
> +++ b/drivers/thermal/renesas/rzg3e_thermal.c
> @@ -461,10 +461,8 @@ static int rzg3e_thermal_probe(struct platform_device *pdev)
>  	ret = devm_request_threaded_irq(dev, irq, rzg3e_thermal_irq,
>  					rzg3e_thermal_irq_thread,
>  					IRQF_ONESHOT, "rzg3e_thermal", priv);
> -	if (ret) {
> -		dev_err(dev, "Failed to request IRQ: %d\n", ret);
> +	if (ret)
>  		goto err_pm_put;
> -	}
>  
>  	/* Add hwmon sysfs interface */
>  	ret = devm_thermal_add_hwmon_sysfs(dev, priv->zone);
> -- 
> 2.34.1
> 

-- 
Kind Regards,
Niklas Söderlund