Re: [PATCH v3 17/22] iommu/amd: Introduce helper function for updating domain ID mapping table

[Suthikulpanit, Suravee]

On 7/7/2026 9:32 PM, Jason Gunthorpe wrote:
> On Mon, Jun 29, 2026 at 03:35:30PM +0000, Suravee Suthikulpanit wrote:
> > +int amd_viommu_domain_id_update(struct amd_iommu *iommu, u16 gid,
> > +				u16 hdom_id, u16 gdom_id)
> > +{
> > +	u64 val;
> > +	u8 __iomem *vfctrl = VIOMMU_VFCTRL_MMIO_BASE(iommu, gid);
> > +
> > +	val = FIELD_PREP(DOMID_ENTRY_GDOMID_MASK, gdom_id) |
> > +	      FIELD_PREP(DOMID_ENTRY_HDOMID_MASK, hdom_id) |
> > +	      DOMID_ENTRY_WRITE | DOMID_ENTRY_VALID;
> > +
> > +	writeq(val, vfctrl + VIOMMU_VFCTRL_GUEST_DID_MAP_CONTROL1_OFFSET);
> > +	return 0;
> > +}
> > +EXPORT_SYMBOL(amd_viommu_domain_id_update);
>
> Why is this exported?
>
> Jason

This is not needed. I'll remove this in V4.

Thanks,
Suravee