Re: [PATCH 1/2] PCI: apple: Integrate pwrctrl API

[Marc Zyngier]

On Tue, 14 Jul 2026 17:57:11 +0100,
Yureka Lilian <yureka@xxxxxxxxxxxxxx> wrote:
> 
> 
> On 7/9/26 14:29, Manivannan Sadhasivam wrote:
> > On Tue, Jul 07, 2026 at 02:58:39PM +0100, Marc Zyngier wrote:
> >> Works fine is one thing. Being consistent with the way the rest of the
> >> driver works is another. pci_pwrctrl_create_device() and
> >> pci_pwrctrl_power_on_device() appear to do exactly what would be
> >> required for a single port. They just needs to be exported made
> >> global/exported.
> >> 
> > I'm fine with exporting pci_pwrctrl_create_device() and
> > pci_pwrctrl_power_on_device() and calling them with per-port np.
> > 
> > - Mani
> 
> In theory I do agree this would work to power on the slots, and I can
> send a v2 of the patch doing it that way, but I don't quite understand
> yet how this fits better with the existing driver code: If this is the
> case, what is the difference between pcie-apple and pcie-qcom and why
> should pcie-qcom use the recursive function but pcie-apple not?

Consistency is important to maintaining any piece of code, and I do
not want to deal with two management models simultaneously.

Furthermore, the qcom stuff is bolted on the side the DWC train wreck,
has to deal with the existing way the DWC driver works, and I see no
reason to be dragged down to that level of horror.

Yes, this is an arbitrary decision.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.