[PATCH 17/61] staging: rtl8723bs: remove rtw_free_cmd_priv wrapper and rename helper

From: Arsenii Pashchenko

Date: Wed Jul 15 2026 - 08:52:34 EST


Remove the redundant rtw_free_cmd_priv() wrapper function from
rtw_cmd.c, which did nothing but call _rtw_free_cmd_priv().

Simplify the code by renaming the internal _rtw_free_cmd_priv()
helper to rtw_free_cmd_priv() and using it everywhere directly. This
eliminates the useless leading underscore naming and reduces call
overhead.

Clean up the old wrapper definition, update the function prototype in
the header file, and adjust all call sites across the driver.

Signed-off-by: Arsenii Pashchenko <ulijg308@xxxxxxxxx>
---
drivers/staging/rtl8723bs/core/rtw_cmd.c | 6 +-----
drivers/staging/rtl8723bs/include/cmd_osdep.h | 1 -
2 files changed, 1 insertion(+), 6 deletions(-)

diff --git a/drivers/staging/rtl8723bs/core/rtw_cmd.c b/drivers/staging/rtl8723bs/core/rtw_cmd.c
index b91182549..02b7d24c3 100644
--- a/drivers/staging/rtl8723bs/core/rtw_cmd.c
+++ b/drivers/staging/rtl8723bs/core/rtw_cmd.c
@@ -227,7 +227,7 @@ void rtw_free_evt_priv(struct evt_priv *pevtpriv)
kfree(pevtpriv->c2h_queue);
}

-void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv)
+void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv)
{
if (pcmdpriv) {
kfree(pcmdpriv->cmd_allocated_buf);
@@ -287,10 +287,6 @@ struct cmd_obj *_rtw_dequeue_cmd(struct __queue *queue)
}


-void rtw_free_cmd_priv(struct cmd_priv *pcmdpriv)
-{
- _rtw_free_cmd_priv(pcmdpriv);
-}

int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj);
int rtw_cmd_filter(struct cmd_priv *pcmdpriv, struct cmd_obj *cmd_obj)
diff --git a/drivers/staging/rtl8723bs/include/cmd_osdep.h b/drivers/staging/rtl8723bs/include/cmd_osdep.h
index 2259fe57a..2afd60a7d 100644
--- a/drivers/staging/rtl8723bs/include/cmd_osdep.h
+++ b/drivers/staging/rtl8723bs/include/cmd_osdep.h
@@ -9,7 +9,6 @@

int rtw_init_cmd_priv(struct cmd_priv *pcmdpriv);
int rtw_init_evt_priv(struct evt_priv *pevtpriv);
-extern void _rtw_free_cmd_priv(struct cmd_priv *pcmdpriv);
extern struct cmd_obj *_rtw_dequeue_cmd(struct __queue *queue);

#endif
--
2.55.0