[PATCH 21/61] staging: rtl8723bs: replace rtw_reset_continual_io_error with atomic_set
From: Arsenii Pashchenko
Date: Wed Jul 15 2026 - 08:57:44 EST
Remove the redundant rtw_reset_continual_io_error() wrapper function
from the driver and replace its call sites with direct atomic_set()
invocations.
The wrapper does nothing but call atomic_set() with a fixed constant
value of 0. Eliminating it simplifies the driver's error-handling
interface and avoids unnecessary call overhead.
Clean up the function definition, remove its prototype from the header
file, and update all invocations to use atomic_set() directly.
Signed-off-by: Arsenii Pashchenko <ulijg308@xxxxxxxxx>
---
drivers/staging/rtl8723bs/core/rtw_io.c | 6 ------
drivers/staging/rtl8723bs/include/rtw_io.h | 2 +-
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 2 +-
drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c | 4 ++--
4 files changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_io.c b/drivers/staging/rtl8723bs/core/rtw_io.c
index c793ae7ea..2692c9088 100644
--- a/drivers/staging/rtl8723bs/core/rtw_io.c
+++ b/drivers/staging/rtl8723bs/core/rtw_io.c
@@ -144,9 +144,3 @@ int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj)
return false;
}
-
-/* Set the continual_io_error of this @param dvobjprive to 0 */
-void rtw_reset_continual_io_error(struct dvobj_priv *dvobj)
-{
- atomic_set(&dvobj->continual_io_error, 0);
-}
diff --git a/drivers/staging/rtl8723bs/include/rtw_io.h b/drivers/staging/rtl8723bs/include/rtw_io.h
index 3c99a2bc1..2c33d8053 100644
--- a/drivers/staging/rtl8723bs/include/rtw_io.h
+++ b/drivers/staging/rtl8723bs/include/rtw_io.h
@@ -33,7 +33,7 @@ struct intf_hdl {
#define MAX_CONTINUAL_IO_ERR SD_IO_TRY_CNT
int rtw_inc_and_chk_continual_io_error(struct dvobj_priv *dvobj);
-void rtw_reset_continual_io_error(struct dvobj_priv *dvobj);
+
struct io_priv {
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
index d2419c776..0adfc2766 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_intf.c
@@ -170,7 +170,7 @@ static struct dvobj_priv *sdio_dvobj_init(struct sdio_func *func)
if (ret)
goto free_dvobj;
- rtw_reset_continual_io_error(dvobj);
+ atomic_set(&dvobj->continual_io_error, 0);
return dvobj;
diff --git a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c b/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c
index e9a2f3f7e..f728594b0 100644
--- a/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c
+++ b/drivers/staging/rtl8723bs/os_dep/sdio_ops_linux.c
@@ -217,7 +217,7 @@ u32 sd_read32(struct intf_hdl *pintfhdl, u32 addr, s32 *err)
sdio_release_host(func);
if (*err == 0) {
- rtw_reset_continual_io_error(psdiodev);
+ atomic_set(&psdiodev->continual_io_error, 0);
break;
}
@@ -293,7 +293,7 @@ void sd_write32(struct intf_hdl *pintfhdl, u32 addr, u32 v, s32 *err)
if (claim_needed)
sdio_release_host(func);
if (*err == 0) {
- rtw_reset_continual_io_error(psdiodev);
+ atomic_set(&psdiodev->continual_io_error, 0);
break;
}
--
2.55.0