[PATCH 52/61] staging: rtl8723bs: inline SetHwRegWithBuf8723B into helper
From: Arsenii Pashchenko
Date: Wed Jul 15 2026 - 09:11:29 EST
Inline the hardware register configuration logic from
SetHwRegWithBuf8723B directly into rtw_hal_set_hwreg_with_buf.
This removes a redundant CamelCase layer for C2H packet handling.
Signed-off-by: Arsenii Pashchenko <ulijg308@xxxxxxxxx>
---
drivers/staging/rtl8723bs/hal/hal_intf.c | 8 +++++++-
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 11 -----------
drivers/staging/rtl8723bs/include/hal_intf.h | 1 -
3 files changed, 7 insertions(+), 13 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/hal_intf.c b/drivers/staging/rtl8723bs/hal/hal_intf.c
index 92e4605fa..e58fc1405 100644
--- a/drivers/staging/rtl8723bs/hal/hal_intf.c
+++ b/drivers/staging/rtl8723bs/hal/hal_intf.c
@@ -128,7 +128,13 @@ void rtw_hal_get_hwreg(struct adapter *padapter, u8 variable, u8 *val)
void rtw_hal_set_hwreg_with_buf(struct adapter *padapter, u8 variable, u8 *pbuf, int len)
{
- SetHwRegWithBuf8723B(padapter, variable, pbuf, len);
+ switch (variable) {
+ case HW_VAR_C2H_HANDLE:
+ C2HPacketHandler_8723B(padapter, pbuf, len);
+ break;
+ default:
+ break;
+ }
}
u8 rtw_hal_get_def_var(struct adapter *padapter, enum hal_def_variable eVariable, void *pValue)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index 22d6180f1..0155c523e 100644
--- a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
+++ b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
@@ -1079,17 +1079,6 @@ void rtw_read_adapter_info(struct adapter *padapter)
}
-void SetHwRegWithBuf8723B(struct adapter *padapter, u8 variable, u8 *pbuf, int len)
-{
- switch (variable) {
- case HW_VAR_C2H_HANDLE:
- C2HPacketHandler_8723B(padapter, pbuf, len);
- break;
- default:
- break;
- }
-}
-
/* */
/* Description: */
/* Query setting of specified variable. */
diff --git a/drivers/staging/rtl8723bs/include/hal_intf.h b/drivers/staging/rtl8723bs/include/hal_intf.h
index b6ceea02a..1d5c0b7bb 100644
--- a/drivers/staging/rtl8723bs/include/hal_intf.h
+++ b/drivers/staging/rtl8723bs/include/hal_intf.h
@@ -241,7 +241,6 @@ s32 rtw_hal_macid_wakeup(struct adapter *padapter, u32 macid);
s32 rtw_hal_fill_h2c_cmd(struct adapter *, u8 ElementID, u32 CmdLen, u8 *pCmdBuffer);
-void SetHwRegWithBuf8723B(struct adapter *padapter, u8 variable, u8 *pbuf, int len);
u8 GetHalDefVar8723BSDIO(struct adapter *Adapter, enum hal_def_variable eVariable, void *pValue);
void UpdateHalRAMask8723B(struct adapter *padapter, u32 mac_id, u8 rssi_level);
void rtl8723b_SetBeaconRelatedRegisters(struct adapter *padapter);
--
2.55.0