Re: [PATCH v4 06/11] console/braille: Lock console->setup() call during the registration

[John Ogness]

On 2026-06-04, Petr Mladek <pmladek@xxxxxxxx> wrote:
> diff --git a/drivers/accessibility/braille/braille_console.c b/drivers/accessibility/braille/braille_console.c
> index 7b324329882f..9ed3abffb687 100644
> --- a/drivers/accessibility/braille/braille_console.c
> +++ b/drivers/accessibility/braille/braille_console.c
> @@ -356,7 +356,9 @@ int braille_register_console(struct console *console, int index,
>  	if (braille_co)
>  		return -ENODEV;
>  	if (console->setup) {
> +		console_lock();
>  		ret = console->setup(console, console_options);
> +		console_unlock();
>  		if (ret != 0)
>  			return ret;
>  	}

This block is open coding an existing helper that was created for
exactly this purpose. The code could look like:

	ret = console_call_setup(console, console_options);
	if (ret != 0)
		return ret;

...if console_call_setup() was (for example) a static inline in
console.h.

For this patch as-is:

Acked-by: John Ogness <john.ogness@xxxxxxxxxxxxx>