Re: [PATCH v4 2/3] drm/xe/i2c: Fix the interrupt handling

[Heikki Krogerus]

> Hi Raag,
> 
> > > > > > -	/* Forward interrupt to I2C adapter */
> > > > > > -	generic_handle_irq_safe(xe->i2c->adapter_irq);
> > > > > > +	xe_i2c_handle_smbus_alert(xe->i2c);
> > > > > 
> > > > > [1] Can we move the below re-assert code to wq now? Or do you suspect any
> > > > > side-effects?
> > > > 
> > > > I think that you know this better than I do. But at this point
> > > > interrupt is cleared, so why should we wait for the wq?
> > > 
> > > When does AMC clear the alert signal? Is it when you query from the wq?
> > > If the answer is yes, there's a possibility we might end up with an
> > > interrupt storm here.
> > > 
> > > > To play it safe, can we change this as a followup if necessary?
> > > 
> > > Sure, I'll leave it to you.
> > 
> > I'll move it to the wq. There are no side-effects.
> 
> Can you check does this work:

Nevermind. I'll send the next version.

Thanks,

-- 
heikki