Re: [PATCH net-next 2/2] net: phy: add DAPU Telecom DAP8210R(I) Gigabit Ethernet PHY driver

[Artem Shimko]

Hi Andrew,

On Wed, Jul 15, 2026 at 12:25 AM Andrew Lunn <andrew@xxxxxxx> wrote:

> Please drop all this. Many PHYs have this sort of facility. We want
> one generic API, probably via ethtool, which all PHYs can follow, not
> N different incompatible APIs.
Got it. I have dropped the entire debugfs interface in v2.

> This can be simplified.
>
> First off, there probably too many phydev_dbg() messages, specially
> for normal case things, using defaults, etc.
Okay.

> of_property_read_u32_array() is documented as not touching the results
> value, if it does not find the property. So you can do:
>
>         u32 ps = DAP8211R_DEFAULT_DELAY_PS;
>         of_property_read_u32(np, prop_name, &ps);
>
>         return dap8211r_delay_ps_to_sel(phydev, ps);
Agree. I will simplify the function as suggested.

> This is one of the less well defined areas. PHY_INTERFACE_MODE_RGMII
> would mean either the PCB is adding the delay, or the MAC. There is no
> reason however why the PHY cannot perform fine tuning, adding a small
> delay, say 150ps. So you should respect the rx-internal-delay-ps and
> tx-internal-delay-ps delays here.
Understood.

Thank you for your review!
--
Best regards,
Artem