Re: [PATCH v4] wifi: brcmfmac: add DPP support

From: Arend van Spriel

Date: Wed Jul 15 2026 - 14:48:13 EST


On 15/07/2026 11:22, HungTsung Huang wrote:
Hi Arend,

Thanks for the clarification.

Could you please confirm whether it is OK to submit the standalone P2P fix
to wireless in parallel to wireless-next origin/main? My understanding is
that the P2P fix does not need to wait for the DPP support patch to be
accepted, since it fixes pre-existing bugs and the DPP patch no longer
depends on it.

Yes. You can submit the P2P fix in parallel. I am not sure if wireless-next is rebased against wireless in a release cycle. Maybe this kind of scenario is a reason to do so.

The reason I added:
+ p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif &&
p2p->bss_idx[P2PAPI_BSSCFG_DEVICE].vif->saved_ie.probe_req_ie_len) {

was that DPP public action frames can be sent through the primary interface
without a P2P device vif being created. The existing peer channel search path
assumed the P2P device vif was always available before accessing saved
Probe Request IEs, which could dereference a NULL vif in that case. However,
I agree this is a pre-existing P2P bug rather than part of DPP support, so I
moved it into the standalone P2P fix patch.
Thanks.

Regards,
Arend