Re: [PATCH v4 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible
From: Krzysztof Kozlowski
Date: Thu Jul 16 2026 - 04:01:43 EST
On Wed, Jul 15, 2026 at 07:19:31PM -0700, muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx wrote:
> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@xxxxxxxxxx>
>
> The Agilex5 SoCDK TSN Config2 board uses a GMII-to-RGMII converter
> implemented as FPGA soft IP between gmac1 and its PHY. This converter
> provides the RGMII TX/RX clock delays. Document a new compatible string
> for this MAC variant so the driver can detect it and configure the
> interface accordingly.
Last sentence is completely redundant. You are not supposed to reference
drivers here. I even EXPLICITLY marked this with BOLD font (as a common
mistake) in DTS101 speech.
Explain why devices are or are not compatible. You claim they are
compatible, but driver still treats them partially incompatible.
Best regards,
Krzysztof