Re: [PATCH] drm/solomon: remove unneeded variables in blit functions

[Javier Martinez Canillas]

Iker Pedrosa <ikerpedrosam@xxxxxxxxx> writes:

Hello Iker,

Thanks for the patch.

> Remove unneeded 'ret' variables in ssd130x_fb_blit_rect(),
> ssd132x_fb_blit_rect(), and ssd133x_fb_blit_rect() functions.
> These functions initialize ret to 0 and return it unchanged,
> so return 0 directly instead.
>
> Fixes: 2258f03989af ("drm/solomon: Move calls to drm_gem_fb_end_cpu*()")
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> Closes: https://lore.kernel.org/oe-kbuild-all/202606301409.I0ctsf41-lkp@xxxxxxxxx/
> Signed-off-by: Iker Pedrosa <ikerpedrosam@xxxxxxxxx>
> ---
> Fix unneeded variable warnings reported by kernel test robot in the Solomon
> SSD130x driver. Three blit functions were initializing 'ret' variables to 0,
> never modifying them, and then returning the unchanged value.
>
> The fix simplifies the code by returning 0 directly, addressing the static
> analysis warnings while maintaining the same functionality.
> ---


>  drivers/gpu/drm/solomon/ssd130x.c | 9 +++------

Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>

I'll push it to drm-misc (drm-misc-next). Thanks!

-- 
Best regards,

Javier Martinez Canillas
Core Platforms
Red Hat