Re: [for-next v4 0/5] ionic: RDMA completion timestamping support

[Leon Romanovsky]

On Thu, Jul 16, 2026 at 02:26:22PM +0530, Abhijit Gangurde wrote:
> Thanks Leon. This is already addressed in https://patchwork.kernel.org/project/linux-rdma/patch/20260617132605.1888205-3-abhijit.gangurde@xxxxxxx/
> which was sent after this series. Happy to rebase if needed.

You need to rebase this, as we moved ib_respond_empty_udata()
from the end of the function to the beginning.

Also, please send this as a separate patch or series.

Thanks.

> 
> 
> On 7/16/26 13:31, Leon Romanovsky wrote:
> > On Wed, Jul 15, 2026 at 06:38:06PM +0530, Abhijit Gangurde wrote:
> > > Hi Jason, Jakub,
> > > 
> > > Gentle ping — if there are no further concerns, could this series be merged
> > > through the rdma tree?
> > Jason requested converting any driver that extends udata to
> > use uverbs_robust_udata.
> > 
> > https://lore.kernel.org/linux-rdma/13-v3-bd56dd443069+49-bnxt_re_uapi_jgg@xxxxxxxxxx/
> > 
> > Thanks
> > 
> > > Thanks,
> > > Abhijit
> > > 
> > > On 6/10/26 21:12, Abhijit Gangurde wrote:
> > > > Hi,
> > > > 
> > > > This series adds RDMA completion timestamp support for ionic.
> > > > 
> > > > It enables PHC registration for RDMA timestamp capability, exposes a PHC
> > > > state page for safe user-space reads, maps that PHC state through RDMA
> > > > ucontext mmap, and extends the RDMA CQE format to carry completion
> > > > timestamps.
> > > > 
> > > > With this, user space can read completion timestamps and convert them to
> > > > wall time with low overhead.
> > > > 
> > > > Provider's PR: https://github.com/linux-rdma/rdma-core/pull/1724
> > > > 
> > > > v4:
> > > >     - Added alias mapping of mlx5_ib_clock_info to ib_uverbs_clock_info
> > > > v3:
> > > >     - Renamed ib_uverbs_phc_state to ib_uverbs_clock_info
> > > >     - Moved mlx5 to use the common clock info structure
> > > >     - Addressed review feedback from Sashiko
> > > >     - https://lore.kernel.org/linux-rdma/20260606050003.3648306-1-abhijit.gangurde@xxxxxxx/
> > > > v2:
> > > >     - changed ionic_phc_state to ib_uverbs_phc_state and moved it under
> > > >       ib_user_verbs.h
> > > >     - https://lore.kernel.org/linux-rdma/20260512092623.1157199-1-abhijit.gangurde@xxxxxxx/
> > > > v1:
> > > >     - https://lore.kernel.org/all/20260401102501.3395305-1-abhijit.gangurde@xxxxxxx/
> > > > 
> > > > Abhijit Gangurde (5):
> > > >     net: ionic: register PHC for rdma timestamping
> > > >     net: ionic: Add PHC state page for user space access
> > > >     RDMA/ionic: map PHC state into user space
> > > >     RDMA/ionic: add completion timestamp to CQE format
> > > >     RDMA/mlx5: move mlx5 clock info to common struct ib_uverbs_clock_info
> > > > 
> > > >    .../infiniband/hw/ionic/ionic_controlpath.c   | 34 ++++++++++
> > > >    drivers/infiniband/hw/ionic/ionic_datapath.c  | 43 ++++++-------
> > > >    drivers/infiniband/hw/ionic/ionic_fw.h        | 12 +++-
> > > >    drivers/infiniband/hw/ionic/ionic_ibdev.h     |  2 +
> > > >    drivers/infiniband/hw/ionic/ionic_lif_cfg.c   |  2 +
> > > >    drivers/infiniband/hw/ionic/ionic_lif_cfg.h   |  1 +
> > > >    .../ethernet/pensando/ionic/ionic_ethtool.c   | 12 ++--
> > > >    .../net/ethernet/pensando/ionic/ionic_if.h    |  1 +
> > > >    .../net/ethernet/pensando/ionic/ionic_lif.c   |  5 +-
> > > >    .../net/ethernet/pensando/ionic/ionic_lif.h   |  3 +-
> > > >    .../net/ethernet/pensando/ionic/ionic_phc.c   | 63 ++++++++++++++++---
> > > >    include/uapi/rdma/ib_user_verbs.h             | 33 ++++++++++
> > > >    include/uapi/rdma/ionic-abi.h                 |  1 +
> > > >    include/uapi/rdma/mlx5-abi.h                  | 15 ++---
> > > >    14 files changed, 179 insertions(+), 48 deletions(-)
> > > >