Re: [PATCH v4 1/2] dt-bindings: qcom,snps-dwc3: Add property indicating presence of eUSB2 phy

[Peter Chen]

On 26-07-16 09:42:35, Krishna Kurapati wrote:
> 
> 
> > 
> > At minimum, dwc3 needs to be reviewed and updated for dwc->hsphy_mode
> > check when configuring GUSB2PHYCFG. Regardless, phy type should not be a
> > usbphy_modes enum as I noted above.
> > 
> We can just add the enum for eusb2 in of.c as pointed by Peter in [1], read
> that in dwc3-qcom.c and use it during suspend resume for interrupt handling
> and to modify the DWC3_GUSB2PHYCFG_EUSB2OPMODE bit once we are modifying it
> in core.
> 

I have seen fewer platforms use "phy_type" at dts for arm64, dwc3
core uses it only for special cases and the code was added for
ten years ago. For the default situation, we may not need to
change DWC3_GUSB2PHYCFG_EUSB2OPMODE value for UTMI+, Thinh, is it
correct?

-- 

Thanks,
Peter Chen