Re: [PATCH 0/2] mm/huge_memory: drop dead split helper variants

From: David Hildenbrand (Arm)

Date: Thu Jul 16 2026 - 07:12:02 EST


On 7/16/26 12:03, Kiryl Shutsemau wrote:
> From: "Kiryl Shutsemau (Meta)" <kas@xxxxxxxxxx>
>
> Two trivial cleanups in the folio split API, found while auditing the
> split helpers for the inode UAF fix [1]:
>
> - can_split_folio() is dead: only the !THP stub remains, no definition
> under CONFIG_TRANSPARENT_HUGEPAGE and no callers. Leftover from an
> earlier cleanup.
>
> - split_folio_to_list_to_order() has no direct callers; its only user
> is split_folio_to_order(), which always passes a NULL list. Fold it.
>
> These were 4/5 and 5/5 of the withdrawn series [2], rebased without the
> memory_failure() dependency. 3/5 (removing split_huge_page_to_order())
> is dropped: with the UAF fixed by [1] instead, memory_failure() keeps
> using it. The syzbot ci failures against [2] were all caused by its
> patch 1, which is gone.
>
> No functional change.

Thanks!

Acked-by: David Hildenbrand (Arm) <david@xxxxxxxxxx>

--
Cheers,

David