[PATCH] drm/imx/tve: take i2c adapter module reference
From: Johan Hovold
Date: Thu Jul 16 2026 - 09:20:43 EST
The i2c subsystem currently blocks during adapter deregistration
whenever there are consumers holding a reference.
Switch to using of_get_i2c_adapter_by_node() which also takes a
reference to the adapter module so that an attempt to unload the module
while in use fails gracefully instead of blocking uninterruptibly.
Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
---
drivers/gpu/drm/imx/ipuv3/imx-tve.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/imx/ipuv3/imx-tve.c b/drivers/gpu/drm/imx/ipuv3/imx-tve.c
index e861b8b9d8fa..389f45d54faa 100644
--- a/drivers/gpu/drm/imx/ipuv3/imx-tve.c
+++ b/drivers/gpu/drm/imx/ipuv3/imx-tve.c
@@ -528,11 +528,11 @@ static const struct component_ops imx_tve_ops = {
.bind = imx_tve_bind,
};
-static void imx_tve_put_device(void *_dev)
+static void imx_tve_put_adapter(void *_adap)
{
- struct device *dev = _dev;
+ struct i2c_adapter *adap = _adap;
- put_device(dev);
+ i2c_put_adapter(adap);
}
static int imx_tve_probe(struct platform_device *pdev)
@@ -554,11 +554,11 @@ static int imx_tve_probe(struct platform_device *pdev)
ddc_node = of_parse_phandle(np, "ddc-i2c-bus", 0);
if (ddc_node) {
- tve->ddc = of_find_i2c_adapter_by_node(ddc_node);
+ tve->ddc = of_get_i2c_adapter_by_node(ddc_node);
of_node_put(ddc_node);
if (tve->ddc) {
- ret = devm_add_action_or_reset(dev, imx_tve_put_device,
- &tve->ddc->dev);
+ ret = devm_add_action_or_reset(dev, imx_tve_put_adapter,
+ tve->ddc);
if (ret)
return ret;
}
--
2.54.0