Re: [PATCH 3/3] arm64: dts: imx8mq-evk: add regulator-off-in-suspend for VGEN1/VGEN6

[Frank Li]

On Thu, Jul 16, 2026 at 11:50:55AM +0800, Joy Zou wrote:
> VGEN1 and VGEN6 have no consumers and are not always-on, causing the
> regulator cleanup work to race with PM suspend.

why cause race? You first patch set workqueue to system_freezable_wq

Frank

> Mark them as
> regulator-off-in-suspend to disable them properly during suspend and
> reduce power consumption.
>
> Signed-off-by: Joy Zou <joy.zou@xxxxxxxxxxx>
> ---
>  arch/arm64/boot/dts/freescale/imx8mq-evk.dts | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> index 5ea04703ddd7..fc0303e44433 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-evk.dts
> @@ -299,6 +299,9 @@ vref_reg: vrefddr {
>  			vgen1_reg: vgen1 {
>  				regulator-min-microvolt = <800000>;
>  				regulator-max-microvolt = <1550000>;
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
>  			};
>
>  			vgen2_reg: vgen2 {
> @@ -328,6 +331,9 @@ vgen5_reg: vgen5 {
>  			vgen6_reg: vgen6 {
>  				regulator-min-microvolt = <1800000>;
>  				regulator-max-microvolt = <3300000>;
> +				regulator-state-mem {
> +					regulator-off-in-suspend;
> +				};
>  			};
>  		};
>  	};
>
> --
> 2.34.1
>
>