Re: [PATCH 2/2] iio: magnetometer: add support for QST QMC6308

[Siratul Islam]

July 16, 2026 at 8:18 PM, "Jorijn van der Graaf" <jorijnvdgraaf@xxxxxxxxxxxxx mailto:jorijnvdgraaf@xxxxxxxxxxxxx?to=%22Jorijn%20van%20der%20Graaf%22%20%3Cjorijnvdgraaf%40catcrafts.net%3E > wrote:


> 
> Hi Sirat,
...
> 
> > 
> > Use reverse x-mas tree order.
> > 
> The natural initializer order is fixed by the dependencies here (map
> comes from data, dev from map), so reverse xmas tree would need the
> assignments split from the declarations; I'd rather keep them
> together.
Yep. Of course. That was a dumb suggestion. Should rely less on my pattern 
recognition. Though, you are only using "*map" it twice in that function, so I'm not sure
if extracting it into a variable is worth it. Specially considering it makes the declarations
look ugly.

That said, I have opinions about your other replies, but I'm a bit busy now so
I'll get back to them later.
> 
...
> 
> Thanks,
> Jorijn
>
--
Best regards,
Sirat