Re: [PATCH 1/2] PCI: Move Spacemit vendor and device ID to linux/pci_Ids.h

[Bjorn Helgaas]

On Wed, Jul 15, 2026 at 10:21:54PM -0500, Anirudh Srinivasan wrote:
> Move the vendor and device IDs for Spacemit PCIe Root Complexes to
> include/linux/pci_ids.h so that they can be referenced elsewhere.
> 
> Signed-off-by: Anirudh Srinivasan <asrinivasan@xxxxxxxxxxxxxxxxxxx>

Acked-by: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>

To help motivate this patch, it would be nice to say specifically
where PCI_VENDOR_ID_SPACEMIT will be used.

In subject line, s/pci_Ids.h/pci_ids.h/

> ---
>  drivers/pci/controller/dwc/pcie-spacemit-k1.c | 4 ----
>  include/linux/pci_ids.h                       | 4 ++++
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-spacemit-k1.c b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> index 680acc93f5395..7b0bc1802954a 100644
> --- a/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> +++ b/drivers/pci/controller/dwc/pcie-spacemit-k1.c
> @@ -21,10 +21,6 @@
>  
>  #include "pcie-designware.h"
>  
> -#define PCI_VENDOR_ID_SPACEMIT		0x201f
> -#define PCI_DEVICE_ID_SPACEMIT_K1	0x0001
> -#define PCI_DEVICE_ID_SPACEMIT_K3	0x0002
> -
>  /* Offsets and field definitions for link management registers */
>  #define K1_PHY_AHB_IRQ_EN			0x0000
>  #define PCIE_INTERRUPT_EN		BIT(0)
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 1c9d40e09107d..d6f26cacc8e35 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2640,6 +2640,10 @@
>  #define PCI_VENDOR_ID_SUNIX		0x1fd4
>  #define PCI_DEVICE_ID_SUNIX_1999	0x1999
>  
> +#define PCI_VENDOR_ID_SPACEMIT		0x201f
> +#define PCI_DEVICE_ID_SPACEMIT_K1	0x0001
> +#define PCI_DEVICE_ID_SPACEMIT_K3	0x0002
> +
>  #define PCI_VENDOR_ID_HINT             0x3388
>  #define PCI_DEVICE_ID_HINT_VXPROII_IDE 0x8013
>  
> 
> -- 
> 2.43.0
>