Re: [PATCH net-next v2 2/2] net: phy: add DAPU Telecom DAP8210R(I) Gigabit Ethernet PHY driver
From: Artem Shimko
Date: Thu Jul 16 2026 - 13:03:05 EST
Hi Andrew,
On Thu, Jul 16, 2026 at 4:55 PM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> > + /* Wait for reset self-clear */
> > + do {
> > + fsleep(20);
> > + ret = dap8211r_read_ext(phydev, DAP8211R_PHY_CON);
> > + if (ret < 0)
> > + return ret;
> > + } while (!(ret & DAP8211R_PHY_SW_RST) && --retries);
>
> This does not have the usual problem, but it is still better to use
> something from iopoll.h.
Thank you! I will replace the manual loop with read_poll_timeout() in v3.
--
Best Regards,
Artem