Re: [PATCH] spi: orion: use devm_clk_get_optional_enabled for axi clock

From: Mark Brown

Date: Thu Jul 16 2026 - 13:32:04 EST


On Wed, Jul 15, 2026 at 03:13:43PM -0700, Rosen Penev wrote:
> Replace the open-coded optional axi clock get/prepare/enable and the
> manual cleanup in probe/remove/runtime_resume with the managed helper
> devm_clk_get_optional_enabled(). This removes the now-unused
> out_rel_axi_clk error path and simplifies the clock lifecycle.

> @@ -804,7 +796,6 @@ static void orion_spi_remove(struct platform_device *pdev)
> spi_unregister_controller(host);
>
> pm_runtime_get_sync(&pdev->dev);
> - clk_disable_unprepare(spi->axi_clk);
>
> pm_runtime_disable(&pdev->dev);
> pm_runtime_put_noidle(&pdev->dev);

This breaks the build since it removes the only use of 'spi' in the
function.

Attachment: signature.asc
Description: PGP signature