Re: [PATCH] dt-bindings: leds: lacie,ns2-leds: Convert to DT schema
From: Rob Herring
Date: Thu Jul 16 2026 - 13:36:28 EST
On Wed, Jul 01, 2026 at 11:23:30PM +0530, Ninad Naik wrote:
> Convert lacie,ns2-leds to DT schema.
>
> Signed-off-by: Ninad Naik <ninadnaik07@xxxxxxxxx>
> ---
> .../bindings/leds/lacie,ns2-leds.yaml | 87 +++++++++++++++++++
> .../devicetree/bindings/leds/leds-ns2.txt | 35 --------
> 2 files changed, 87 insertions(+), 35 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/leds/lacie,ns2-leds.yaml
> delete mode 100644 Documentation/devicetree/bindings/leds/leds-ns2.txt
>
> diff --git a/Documentation/devicetree/bindings/leds/lacie,ns2-leds.yaml b/Documentation/devicetree/bindings/leds/lacie,ns2-leds.yaml
> new file mode 100644
> index 000000000000..679a618906d8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/lacie,ns2-leds.yaml
> @@ -0,0 +1,87 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/lacie,ns2-leds.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Dual-GPIO LEDs found on Network Space v2 (and parents)
> +
> +maintainers:
> + - Lee Jones <lee@xxxxxxxxxx>
> + - Pavel Machek <pavel@xxxxxxxxxx>
This should be someone with the h/w, not subsystem maintainers.
> +
> +description: |
Dont need '|'.
> + The Network Space v2 dual-GPIO LED is wired to a CPLD. Three different LED
> + modes are available: off, on and SATA activity blinking. The LED modes are
> + controlled through two GPIOs (command and slow): each combination of values
> + for the command/slow GPIOs corresponds to a LED mode.
Rest looks fine.
Rob