Re: [PATCH] drm/panel-edp: take i2c adapter module reference

[Doug Anderson]

Hi,

On Thu, Jul 16, 2026 at 6:22 AM Johan Hovold <johan@xxxxxxxxxx> wrote:
>
> The i2c subsystem currently blocks during adapter deregistration
> whenever there are consumers holding a reference.
>
> Switch to using of_get_i2c_adapter_by_node() which also takes a
> reference to the adapter module so that an attempt to unload the module
> while in use fails gracefully instead of blocking uninterruptibly.
>
> Signed-off-by: Johan Hovold <johan@xxxxxxxxxx>
> ---
>  drivers/gpu/drm/panel/panel-edp.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Worth adding any "Fixes:" tag? I guess this has been using
of_find_i2c_adapter_by_node() for a long time...

Sashiko-bot review [1] seems right, even though it's pointing out
something that isn't really a new problem and is very much a corner
case where someone is crafting an intentionally ridiculous device
tree. If you agree, I wouldn't mind a followup patch fixing that, too.
;-)

[1] https://lore.kernel.org/r/20260716133420.187131F000E9@xxxxxxxxxxxxxxx/