Re: [PATCH] perf build: Fix a compiler error in util/libbfd.c

[Namhyung Kim]

Hi Ian,

On Wed, Jul 15, 2026 at 07:44:53PM -0700, Ian Rogers wrote:
> On Wed, Jul 15, 2026 at 5:43 PM Namhyung Kim <namhyung@xxxxxxxxxx> wrote:
> >
> > The bfd_boolean type was gone and converted to the standard bool type
> > but we have some old code that uses the type.  It caused a failure in
> > the build test.
> >
> >   util/libbfd.c: In function 'slurp_symtab':
> >   util/libbfd.c:94:9: error: unknown type name 'bfd_boolean'
> >      94 |         bfd_boolean dynamic = FALSE;
> >         |         ^~~~~~~~~~~
> >   util/libbfd.c:94:31: error: 'FALSE' undeclared (first use in this function)
> >      94 |         bfd_boolean dynamic = FALSE;
> >         |                               ^~~~~
> >   util/libbfd.c:94:31: note: each undeclared identifier is reported only once for each function it appears in
> >   util/libbfd.c:102:27: error: 'TRUE' undeclared (first use in this function)
> >     102 |                 dynamic = TRUE;
> >         |                           ^~~~
> >
> > Fix it with standard bool type and constants.
> >
> > Link: https://sourceware.org/pipermail/binutils-cvs/2021-March/056231.html
> > Signed-off-by: Namhyung Kim <namhyung@xxxxxxxxxx>
> 
> Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>
> 
> Should we add a fixes tag for backports? It's not clear we can provide
> a sensible SHA.

Thanks for your review.  Yep, the file was moved and it had the bug
before.  I was thinking about adding SHA of the move but not sure if
it's really worth it.

Thanks,
Namhyung